[Bug]: 500 error at Loans Dashboard task on loan with no 'date sent'

SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.

http://taxonworks.org

MIT License

87 stars 27 forks source link

[Bug]: 500 error at Loans Dashboard task on loan with no 'date sent' #4001

Closed kleintom closed 3 months ago

kleintom commented 3 months ago

Steps to reproduce the bug

1. Go to /tasks/loans/dashboard
2. Get a 500 saying `undefined method `+' for nil` at line 162:
`data.last[:data][d&.year] += t if t`
3. 
...

Screenshot

No response

Expected behavior

No response

Additional Screenshots

No response

Environment

Sandbox, Development (docker)

Sandbox Used

No response

Version

7f58d67aed97f35fdd4ef3db6ceb

Browser Used

No response

kleintom commented 3 months ago

I'm getting this on my local and sandbox projects - it might have to do with the minimalist toy loans I've created there.

kleintom commented 3 months ago

Yeah this might be due to loans with no dates entered when I was testing a pr back in January or so - unless anyone else is seeing this it can maybe be closed, I'll look into it more.

kleintom commented 3 months ago

Updated steps to reproduce:

Create at least one loan with no date sent that has either an otu or a CO loan item.
Load the Loans Hub task See a 500 error.