search

SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.
http://taxonworks.org
Other
86 stars 25 forks source link

DwC occurrence importer: multiple matches with Root parent fails #4072

Open LocoDelAssembly opened 1 day ago

LocoDelAssembly commented 1 day ago

On dataset which only have scientificName, the importer uses the project root as parent. In the event of two or more protonyms being matched, the importer resolves to use the calculated parent (Root), which has no OTU and results in a confusing message: image

Related commit: https://github.com/SpeciesFileGroup/taxonworks/commit/d1ecc63ab529ea43e3eb2a9857f1c238ace62a60

ADDITIONAL TESTING: Actually Root may have OTU, tried navigating into browse otu and it was created automatically, then retried import and "worked" (CO was determined as Root).

However not sure this ambiguity should be resolved silently, but starting to make it fail might break AntWeb usage.

LocoDelAssembly commented 1 day ago

Perhaps in cases where the project root name is selected we should consider creating an OTU with name attribute equal to scientificName? (At least I think it is better than just silently using Root)

In other cases of parents lower than Root, maybe we should consider doing the same thing, if parent rank is higher than genus?

mjy commented 1 day ago

project root name is selected we should consider creating an OTU with name attribute equal to scientificName? (At least I think it is better than just silently using Root)

At minimum this is a good option to make available. See also other tests coming re otu#name formation.