SpeciesFileGroup / taxonworks

Workbench for biodiversity informatics.
http://taxonworks.org
MIT License
87 stars 26 forks source link

Request - Allow RecordNumber to be not unique #4096

Closed camwebb closed 2 weeks ago

camwebb commented 2 weeks ago

Because in botany we often make duplicate (up to 5 or more) collections of the same organism (or population) under a single collector's number, different physical specimens at different herbaria will have different catalog numbers but the same record number. Currently in TW two records with the same RecordNumber is not allowed, requiring addition of, e.g. @K or at ALA to the Record number. This will 'dirty' the data for export. Can we please allow records with non-unique RecordNumbers? Thanks

debpaul commented 2 weeks ago

@camwebb understood! I think while it's a kind of "localIdentifier", hence the way it's currently modeled, indeed it has this nature you describe. Perhaps best imported into TaxonWorks as a Data Attribute of the CO, instead of a formalized identifier. Will have to wait and see what @mjy and @LocoDelAssembly have to say.

mjy commented 2 weeks ago

It's an Identifier, and needs to be modelled as such, we can remove the restriction.

camwebb commented 2 weeks ago

we can remove the restriction

Thanks

LocoDelAssembly commented 2 weeks ago

@mjy can or cannot?

mjy commented 2 weeks ago

can , we can skip the validation callback I think, but I'll have to test if that actually works