search

Specifyapp / parsers

Specify helps you unify your brand identity by collecting, storing and distributing design tokens and assets — automatically.
https://specifyapp.com
Other
111 stars 15 forks source link

Feat: Adding inline-css-variables-in-svg #174

Closed JulesGuesnon closed 1 year ago

JulesGuesnon commented 1 year ago

What it does

This PR adds inline-css-variables-in-svg parser. It allows to replace all the stroke and fill values by a Css variable if a matching color token exists

Additional informations

I need some feedbacks on a few points:

  1. Currently the cssVariablesFormat option has no default value, should It?
  2. To make the parser test works, it required to update seeds.json, but now some of the tests are broken (mostly snapshots). I only need a confirmation that it's the correct way of doing it before I fix all the tests.
  3. I made a README.md based on the other parsers, feel free to tell me if there's lacking informations
JulesGuesnon commented 1 year ago

@AMoreaux I think everything is good for review 🎉