fix: BED-4954 - Include SyncedToADUser and SyncedToEntraUser in Delet…

[zinic]

Description

Azure Post is missing SyncedToADUser: https://github.com/SpecterOps/BloodHound/blob/c347ed2bfa2d524494657269ab23828674f74376/packages/go/analysis/azure/post.go#L120

ActiveDirectory Post is missing SyncedToEntraUser: https://github.com/SpecterOps/BloodHound/blob/c347ed2bfa2d524494657269ab23828674f74376/packages/go/analysis/ad/post.go#L37

Lastly, as written the resulting query from DeleteTransitEdges(...) narrows the start and end node kinds to just one base type: (:Base)-[:SyncedToEntraUser]->(:Base). This presents a problem since AD/Entra Hybrid Paths, by definition, must cross boundaries: (:Base)-[:SyncedToEntraUser]->(:AZBase). As such, the DeleteTransitEdges(...) function must be rewritten to match on multiple start and end node kinds.

Motivation and Context

This PR addresses: BED-4954

Calls to DeleteTransitEdges(…) do not include the most recent AD/Entra Hybrid Path edges. Additionally, due to the way that the function is written, cross-domain edges will never be deleted.

How Has This Been Tested?

Integration testing.

Screenshots (optional):

Types of changes

• Chore (a change that does not modify the application functionality)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Database Migrations

Checklist:

• [ ] I have met the contributing prerequisites
  • Assigned myself to this PR
  • Added the appropriate labels
  • Associated an issue: https://github.com/SpecterOps/BloodHound/issues/672
  • Read the Contributing guide: https://github.com/SpecterOps/BloodHound/wiki/Contributing
• [ ] I have ensured that related documentation is up-to-date
  • Open API docs
  • Code comments (GoDocs / JSDocs)
• [ ] I have followed proper test practices
  • Added/updated tests to cover my changes
  • All new and existing tests passed