search

SpectraCollab / ORMIR_XCT

Code developed at the 2022 ORMIR workshop in Maastricht, Netherlands
GNU General Public License v3.0
4 stars 0 forks source link

`ipl_seg` the `sigma` and `support` should be parameters, not hard-coded #3

Closed njneeteson closed 1 year ago

njneeteson commented 1 year ago

In ipl_seg currently sigma is hard-coded to be 0.5. In Danielle's guidelines for HR-pQCT standard distal site analysis, the recommended value is sigma=0.8 for filtering before thresholding cortical and trabecular bone. I'm noticing some differences in my microarchitectural parameters and I think this discrepancy is why.

I can easily resolve this by refactoring the ipl_seg function to have sigma and support as optional arguments and set the default values as what you have now (sigma=0.5, support=1). However just checking if you're fine with that resolution before I go ahead.

mkuczyns commented 1 year ago

That sounds good to me! You can go ahead with the change.

njneeteson commented 1 year ago

I made sigma a kwarg already and I think that's sufficient for now. I'm going to close this and if anyone needs support to also be a kwarg in the future they can do it.