search

SpectralSequences / sseq

The root repository for the SpectralSequences project.
Apache License 2.0
22 stars 10 forks source link

Error handling for custom modules in web UI #126

Closed hoodmane closed 8 months ago

hoodmane commented 1 year ago

JD tried to upload a Bruner module definition format file and complained that we provided no error message. Ideally it would be nice if we caught the invalid JSON error and indicated in some way that the module file is incorrect.

JoeyBF commented 1 year ago

What would be the steps to reproduce? I forget where we upload these

hoodmane commented 1 year ago

Sorry, should have given more details!

  1. Go to https://spectralsequences.github.io/sseq/
  2. Hit "upload" button
  3. Add a file that does not contain valid JSON
JoeyBF commented 1 year ago

Got it, I'll check it out. Thanks!

hoodmane commented 1 year ago

I suspect that there are similar problems if the file has valid json but is in some way an invalid module definition...

hoodmane commented 1 year ago

Thanks @JoeyBF!