SpectralSequences / sseq

The root repository for the SpectralSequences project.
Apache License 2.0
25 stars 10 forks source link

Replace FiniteModule with dynamic dispatch #80

Closed dalcde closed 2 years ago

dalcde commented 2 years ago

This cleans up quite a bit of boilerplate code.

This makes resolve_through_stem slightly slower (~2-4%) without nassau, and has no performance impact with nassau. Since large computations should be done with nassau, and the impact is probably asymptotically negligible, I think this is fine.

@hoodmane do you mind having a look and see if this will be problematic for the python bindings? (I hope it makes things better, but you never know...)

dalcde commented 2 years ago

Merged manually