SpectralSequences / sseq

The root repository for the SpectralSequences project.
Apache License 2.0
25 stars 10 forks source link

Add coordinate abstractions #95

Closed JoeyBF closed 1 year ago

JoeyBF commented 2 years ago

I saw Jason had interesting code that handles bidegrees and bigraded vector spaces, so I ported it here with some modifications. Upstreamed from jassch/AdamsSSMasseyProductCalculator.

It remains to modify the rest of the code to use this machinery, but I wanted to get comments first.

dalcde commented 1 year ago

Haven't read through the code closely, but it is probably easier to make the s/t fields of Bidegree pub

JoeyBF commented 1 year ago

Haven't read through the code closely, but it is probably easier to make the s/t fields of Bidegree pub

I didn't want to do that because we might want to change the internal representation at some point

JoeyBF commented 1 year ago

I'll merge this PR next Friday if there aren't any more comments

hoodmane commented 1 year ago

Thanks @JoeyBF!

JoeyBF commented 1 year ago

No problem!