Spectrum-CETB / LesKollab

This is a project sharing and collaborations application

MIT License

29 stars 57 forks source link

Issue #3 Fixed - Modal Form Created and linked to "Find a Partner" Button #41

Closed Nikitha2309 closed 3 years ago

Nikitha2309 commented 3 years ago

3 - A Modal Form has been created and linked to the "Find a Project Partner" Button".

Description

All frontend regarding the issue is implemented.
No new dependency required to be installed
Changed Files -
- LesKollab\assets\css\styles.css
- LesKollab\index.php

Type of Change:

Delete irrelevant options.

Code
User Interface

Code/Quality Assurance Only

This change requires a documentation update (software upgrade on readme file)
- Documentation about the "Find a Project Partner" Button is to be updated.
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I have run the project locally after implementing the feature and there is no glitch found. Here is the video of the output of the test run.

https://user-images.githubusercontent.com/66035321/111887430-09414080-89fb-11eb-9921-ef8c4282c50c.mp4

Nikitha2309 commented 3 years ago

I believe slow improvements to the project help improving the project smoothly without more conflicts. Resolving issues step by step helps us to focus more on each step and thereby results in a good website.

Also to fix #3 , I assume only implementing a modal form with required fields as inputs and connecting this to the "Find a Project Partner" button are the tasks that need to be fulfilled.

I have fixed the issue and tested it. Hence I request @rupeshmohanty to review and merge the PR and close it.

Nikitha2309 commented 3 years ago

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

rupeshmohanty commented 3 years ago

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

Nikitha2309 commented 3 years ago

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

I will get a popup modal form and required fields are taken as input, as shown in the video . I will be glad to help with any parts if not understood, thank you

rupeshmohanty commented 3 years ago

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

I will get a popup modal form and required fields are taken as input, as shown in the video

Okay let the mentors check the code, then I will merge the code.

Nikitha2309 commented 3 years ago

@sakshi300699 @ishubham21 @C3Suryansu @anika-001 @rupeshmohanty Can someone pls review and merge my PR?

What happens once you click on find a partner?

I will get a popup modal form and required fields are taken as input, as shown in the video

Okay let the mentors check the code, then I will merge the code.

Thank You, I have already asked @anika-001 to review my code, and I got a reply in the discord channel that everything is fine. You can check there once :)

Nikitha2309 commented 3 years ago

Thanks for the support guys 😀