search

Spectrum-CETB / LesKollab

This is a project sharing and collaborations application
MIT License
28 stars 57 forks source link

organized_code #65

Closed asmitsirohi closed 3 years ago

asmitsirohi commented 3 years ago

I Organized the code of Dashboard, because Whenever other contributor want to contribute new feature then he/she have to repeat code of header, footer, navbar and modal.

Solution: I break the code of Explore/index.php file into header.php, footer.php, navbar.php, modals.php files which is present in components/common folder.

fixes #59

Here is the demonstrated video :

https://user-images.githubusercontent.com/63240102/113553207-08242c00-9615-11eb-8273-3e69f7156d6b.mp4

asmitsirohi commented 3 years ago

@sakshi300699 mam, Here is screenshot of footer.php file image

sakshi300699 commented 3 years ago

@asmitsirohi Shouldn't the footer code be in this file?

asmitsirohi commented 3 years ago

@sakshi300699 mam, Actually there is no code for footer is present in Explore/index.php file. I just created footer.php for future reference.

asmitsirohi commented 3 years ago

It showing "This branch has conflicts that must be resolved", Can you please specify me what is the conflict. So I can resolve it.

image

sakshi300699 commented 3 years ago

@asmitsirohi Check the conflicted files mentioned. Explore/index.php file

asmitsirohi commented 3 years ago

@sakshi300699 mam, I resolved the conflict. Please Check it now.

sakshi300699 commented 3 years ago

Sure! @asmitsirohi