search

Spectrum-CETB / LesKollab

This is a project sharing and collaborations application
MIT License
28 stars 57 forks source link

[Gssoc'21] 404 page #72

Closed arpit456jain closed 3 years ago

arpit456jain commented 3 years ago

Is your feature request related to a problem? Please describe. There was no 404 page . I want to make a 404.html page for website

arpit456jain commented 3 years ago

@rupeshmohanty. @ishubham21 I had written the code to handle 404 error. now i just wanted to ask should i make the 404 page from scratch or i can take it from internet which is freely available ? like i found this one. its looking pretty good

404
arpit456jain commented 3 years ago
4042

this one is also good

arpit456jain commented 3 years ago

@sakshi300699 can you please guide me on this.

ishubham21 commented 3 years ago

I guess it would be better if you could design a page from scratch, this would ensure a uniform theme and UI across the website.

arpit456jain commented 3 years ago

ok

arpit456jain commented 3 years ago

https://user-images.githubusercontent.com/55352601/114344443-791b9480-9b7d-11eb-98d0-ab7203e9f425.mp4

@ishubham21 how is it now?

sakshi300699 commented 3 years ago

@arpit456jain This is looking good! Did u make this from scratch?

arpit456jain commented 3 years ago

@arpit456jain This is looking good! Did u make this from scratch?

No @sakshi300699 i had taken help from code pen

arpit456jain commented 3 years ago

@sakshi300699 kindly review my PR #80

So i can make a PR for this

ishubham21 commented 3 years ago

2021-04-12.10-54-08.mp4 @ishubham21 how is it now?

Great work!

arpit456jain commented 3 years ago

@ishubham21 kindly review my open pr #80 So i can make pr for this

sakshi300699 commented 3 years ago

@sakshi300699 kindly review my PR #80

So i can make a PR for this

Sure!