Add libpurple status text "mood"

SpectrumIM / spectrum2

Spectrum 2 IM transports

https://spectrum.im

408 stars 91 forks source link

Add libpurple status text "mood" #200

Open Fank opened 7 years ago

Fank commented 7 years ago

I saw by adding the "sykpe4pidgin" to pidgin that all contacts have a "mood" text. But not those who came through spectrum.

Btw i also noticed some online/offline inconsistent.

vitalyster commented 7 years ago

What is your client? "Mood" text should be changed with XMPP presence's status text, isn't it?

Fank commented 7 years ago

Pidgin 2.12.0 (libpurple 2.12.0) I don't know, i think so.

I found:

https://github.com/EionRobb/skype4pidgin/blob/7aeffa76577108854a3a4200b930207e9db31349/skypeweb/skypeweb_contacts.c#L1062 where the mood is set
https://github.com/EionRobb/skype4pidgin/blob/aa9ddd71b7c1f2d3c596e2e3b77f389c08bb2f38/skypeweb/libskypeweb.c#L796 where it could be accessed

Fank commented 7 years ago

It could be that the presence's status definitions are static and the message is NULL so it may transported somewhere else.

https://github.com/EionRobb/skype4pidgin/blob/aa9ddd71b7c1f2d3c596e2e3b77f389c08bb2f38/skypeweb/libskypeweb.c#L153

Fank commented 7 years ago

and yea https://xmpp.org/rfcs/rfc3921.html#presence 5.3 tell that it should be transported via <status>

vitalyster commented 7 years ago

So you can change your "mood text" in client, verify client is generate presence for this and it is delivered to spectrum, and if it is not reflects on skype side - then it is a spectrum bug

Fank commented 7 years ago

Ah wait, the problem is that the mood will not be transported from skype -> spectrum -> pidgin.

skype -> pidgin works.

Dont know if pidgin -> spectrum -> skype has issues

Fank commented 7 years ago

@vitalyster enough info?