SpectrumIM / spectrum2

Spectrum 2 IM transports
https://spectrum.im
408 stars 91 forks source link

Backend sends invalid caps #205

Open Ri0n opened 7 years ago

Ri0n commented 7 years ago

to join skype groupchat it's necessary try to add groupchat in roster in pidgin, it will show groupchat id. something like 52:bade5db85a854843ebae8d9ed86ca96d@thread.skype

Then replace : with %3A, and @ with % and join!

Expected: Anything without manual replacing and better without hashes =)

vitalyster commented 7 years ago

That's your client should escape jids using XEP-0106 :)

Fank commented 7 years ago

its working as intended (listing + joining), in pidgin image

Fank commented 7 years ago

@Ri0n what clients are you using?

Ri0n commented 7 years ago

Psi. I'll check others. I believe something wrong with service discovery in Psi. And I'll report more bugs related to skype later. particularly outoging messages are lost.

Ri0n commented 7 years ago

Well service discovery in Gajim on Skype transport doesn't work too. I'm logged in to Skype and see my contacts online but the transport is grayed-out and only "register" button is active.

Fank commented 7 years ago

Could you try pidgin?

Ri0n commented 7 years ago

I can't for now. It stopped showing itself in tray. I guess it's somehow incompatible with kde. I'll try from another computer later.

Ri0n commented 7 years ago

I've found the source of the problem with disco. It's duplicated caps. My skype.localhost in its presence sends me exactly the same caps as in my own presence. So Psi does not try to do disco#info and just gets own info from cache.

Ri0n commented 7 years ago

I solved this for Psi like this https://github.com/psi-im/psi/commit/37f4ca183364e0ee4984994b8719ffdd1ddff645

Ri0n commented 5 years ago

I'm glad it's fixed finally! thanks @vitalyster !

Ri0n commented 5 years ago

so I'm rolling back my workaround in Psi.

Ri0n commented 5 years ago

In fact it wasn't fixed in Spectrum and this bug affects more users now (probably with spreading libpurpple based transports)