Open mbirth opened 5 years ago
can you please try to add oob_split=false
into [service]
config section and try again?
Now it works again (and looks like before, i.e. clients show the HTML part of the message incl. the "View full image" link, history shows link to image only).
Great, so it is the issue of the new oob split feature, I did disable it from being defaults
cc @himselfv
On it
@mbirth
Are you sure the backend log is from 2.0.12? The backend stopped saying "New IMAGE body" some time ago and it currently just says "new BODY". (plus it's trace
, not info
now)
@himselfv Not exactly sure, but I'm pretty sure I've restarted spectrum2 after updating. However, after enabling oob_split again and restarting everything, the bug still exists. No image received in any client.
backend.log
17147: 2019-07-18 18:41:21,338 INFO backend: conv_write_im()
17147: 2019-07-18 18:41:21,338 DEBUG backend: conv_write_im(): msg='<a href='https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG'>View full image <img id='1' src='https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG' /></a>', flags=4098
17147: 2019-07-18 18:41:21,338 DEBUG backend: Received image body='<a href='https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG'>View full image <img id='1' src='https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG' /></a>'
17147: 2019-07-18 18:41:21,339 DEBUG backend: Image ID = '1' 163 164
17147: 2019-07-18 18:41:21,339 INFO libpurple: imgstore:retrieved image id 1
17147: 2019-07-18 18:41:21,342 DEBUG backend: Storing image to /var/www/html/chat/uploads/da28856ca018eed0edf1b9f0b9813734895a3a02.jpg
17147: 2019-07-18 18:41:22,262 INFO libpurple: http:Performing new request 0xaaaafcbbf000 to clients6.google.com.
17147: 2019-07-18 18:41:22,263 INFO libpurple: http:Performing new request 0xaaaafcb62af0 to clients6.google.com.
17147: 2019-07-18 18:41:22,609 INFO libpurple: http:Request 0xaaaafcb62af0 performed successfully.
17147: 2019-07-18 18:41:22,610 INFO libpurple: hangouts:A 'SetFocusResponse' says 'csfrp'
spectrum2.log
2019-07-18 18:41:20,814 INFO ConversationManager: mbirth@myserver.com: Adding conversation 101602501167992504565
2019-07-18 18:41:20,819 INFO Component.RAW: RAW DATA OUT <message from="101602501167992504565@hangouts.myserver.com/bot" to="mbirth@myserver.com" type="chat"><body></body><html xmlns="http://jabber.org/protocol/xhtml-im"><body xmlns="http://www.w3.org/1999/xhtml"><html/></body></html><active xmlns="http://jabber.org/protocol/chatstates"/></message>
2019-07-18 18:41:21,419 DEBUG NetworkPluginServer: wrapIncomingMedia: matchCount==1
2019-07-18 18:41:21,421 INFO Component.RAW: RAW DATA OUT <message from="101602501167992504565@hangouts.myserver.com/bot" to="mbirth@myserver.com" type="chat"><body>View full image https://xmpp.myserver.com/uploads/da28856ca018eed0edf1b9f0b9813734895a3a02.jpg <</body><html xmlns="http://jabber.org/protocol/xhtml-im"><body xmlns="http://www.w3.org/1999/xhtml"><a href="https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG">View full image</body></html><active xmlns="http://jabber.org/protocol/chatstates"/></message>
2019-07-18 18:41:21,426 INFO Component.RAW: RAW DATA OUT <message from="101602501167992504565@hangouts.myserver.com/bot" to="mbirth@myserver.com" type="chat"><body>https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG</body><html xmlns="http://jabber.org/protocol/xhtml-im"><body xmlns="http://www.w3.org/1999/xhtml"><img src='https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG' alt='' /></body></html><x xmlns='jabber:x:oob'><url>https://lh3.googleusercontent.com/-x0EjrNBIqcI/XTChMPa9ZiI/AAAAAAAAACU/kfmodM8SKH8ZPfwic6oOsHXJiQat_ravwCK8BGAs/s0/IMG_0664.JPG</url></x><active xmlns="http://jabber.org/protocol/chatstates"/></message>
2019-07-18 18:41:21,428 INFO Component.RAW: RAW DATA OUT <message from="101602501167992504565@hangouts.myserver.com/bot" to="mbirth@myserver.com" type="chat"><body>></body><html xmlns="http://jabber.org/protocol/xhtml-im"><body xmlns="http://www.w3.org/1999/xhtml"></a></body></html><active xmlns="http://jabber.org/protocol/chatstates"/></message>
2019-07-18 18:41:21,429 INFO Component.RAW: RAW DATA IN <stream:error><not-well-formed xmlns='urn:ietf:params:xml:ns:xmpp-streams'/><text xml:lang='en' xmlns='urn:ietf:params:xml:ns:xmpp-streams'>mismatched tag</text></stream:error>
2019-07-18 18:41:21,430 INFO Component.RAW: RAW DATA OUT </stream:stream>
2019-07-18 18:41:21,430 INFO Component.RAW: RAW DATA IN </stream:stream>
2019-07-18 18:41:21,441 INFO Component: Disconnected from Frontend server. Error: Unexpected element error
@mbirth backend log should start with backend version
This seems right, thanks!
The problem is with <a ...><img></a>
structure which is too complicated for the naive splitting implemented. I'll do HTML-aware splitting but oob_split
is a workaround for certain clients anyway so it's okay to run without it.
Since upgrading from 2.0.10 to 2.0.12 I can't receive images/photos from purple-hangouts anymore. Usually they popped up in Gajim and/or Conversations as a HTML message (with "View full image" link pointing to googleusercontent.com and a thumbnail) and were stored in the MAM history as only the link to the jpg at googleusercontent.com.
Since the upgrade, I don't even get notified when someone sends me a photo. Nothing happens in any client. Also no entry appears in the history.
backend.log:
spectrum2.log:
I've set this in
hangouts.cfg
:And from the log above, it seems to download the thumbnail and put it into
web_directory
just fine (it's there, I've checked). (I believe this worked before this way, too.) But it fails to send the generated message to me.