search

SpectrumIM / spectrum2

Spectrum 2 IM transports
https://spectrum.im
409 stars 90 forks source link

Delivery of offline messages #65

Open Ghabry opened 9 years ago

Ghabry commented 9 years ago

This is more a question about the implementation then a bug report.

spectrum2 is configured to run in "server mode" and to use the "purple backend"

I play around with spectrum2 since a few days and noticed that offline messages are not properly delivered. But I'm not really sure if this is a problem with the plugins I tested, because at least for prpl-jabber the delivery worked.

I tried to work around this issue by setting spectrum2 to bouncer mode (transport setting "Stay connected to legacy network when offline on XMPP") to hold the connection when I disconnect. But the delivery of offline-messages does still not work when reconnecting, actually spectrum2 just "eats" the messages and they are gone.

By looking at the code the message buffering and playback is implemented, but only works in Gateway mode.

Is there a reason why this isn't implemented for server mode? I created a quick&dirty patch (needs some cleanup ^^) that fixes message-buffering and -playback in server mode. Is there any interest in this?

vitalyster commented 9 years ago

It should work in server mode, but yes, patches are welcome

jankaluza commented 8 years ago

Do you still have that patch? Even if it's not perfect, it would help us.

Ghabry commented 8 years ago

Sorry, I completely missed this message here. Never checked the Repo anymore because I thought spectrum2 is dead.

Are you still interested in the patch?

mcepl commented 8 years ago

Try him by attaching it ;)

vitalyster commented 7 years ago

ping?

TomTheDragon commented 8 months ago

I am running Spectrum2 as a transport for F-Chat (libpurple backend) and they dont support offline messages at all. Its nice that you can tell Spectrum2 to keep running all the time, so that the messages others try to send you get buffered, but it unfortunately does not work the other way around. Are there other ways this could get accomplished? I mean i used a function on plugin back and the day (offlinemsg from the core pack), which held all messages i wanted to send towards others until they were online again, something like could work here.