SpectrumQT / XXMI-Launcher

GNU General Public License v3.0
126 stars 5 forks source link

[GIMI] Persistent variables are not being saved to d3dx_user.ini upon game close #13

Closed lupomikti closed 1 month ago

lupomikti commented 1 month ago

Variables marked as persistent are not having their values saved in d3dx_user.ini when closing the game through normal means (opening the Paimon menu, clicking on Quit to get to the login screen, then clicking on Exit to exit the game). These variables are properly saved upon pressing the F10 shortcut to reload mods; it is only with game closure that the file is not being written to.

Environment:

Workaround: Since pressing F10 does save the persistent variables, the current workaround is to simply press this key before exiting the game.

SpectrumQT commented 1 month ago

It's expected behaviour of default 3dmigoto DLL. Adding auto-save to those vars is in my TODO list with low prio.

lupomikti commented 1 month ago

Cool, understood. If I wanted to work on that specific functionality myself, where would I be able to do that (and then submit a MR)? I'm guessing your 3DMigoto fork? I see the readme there is quite out-of-date, so what should I be aware of for development?

SpectrumQT commented 1 month ago

Yes, it's SpectrumQT/3Dmigoto repo. And yes, readme is just from cloned OG 3dmigoto repo. But you can read the list of commits to become up to date with what was changed by me.