Specy / genshin-music

A music composer and song learning webapp made for the games Genshin and Sky Cotl. Made with Next.js, WebMIDI, WebAudio, pixi.js
https://specy.app/
MIT License
132 stars 35 forks source link

About New Instruments #35

Closed cangerjun closed 4 months ago

cangerjun commented 6 months ago

Today, Genshin Impact 4.6 forward-looking live broadcast added a new Instrument, it looks like an french horn

Specy commented 6 months ago

Yes I saw, there is one issue for implementing it, which is the instrument is able to be "held down" to play long notes, the app currently has no support for that so I'll have to do a big rework to add that, it's gonna take a while

ptr2019 commented 6 months ago

Yes I saw, there is one issue for implementing it, which is the instrument is able to be "held down" to play long notes, the app currently has no support for that so I'll have to do a big rework to add that, it's gonna take a while

That's great >v< Look forward to the newly implemented instrument. No such attempt has been found elsewhere. How is the implementation going?

Specy commented 6 months ago

Right now i'm working to add translations to the app, after that is done i'll start with this

cangerjun commented 5 months ago

I see the mode of 'have Do Re Mi' in NOTE NAME tpye. Can you add another numerical version? 1 2 3 4 5 6 7

Specy commented 5 months ago

I see the mode of 'have Do Re Mi' in NOTE NAME tpye. Can you add another numerical version? 1 2 3 4 5 6 7

Sure, would the numbers then repeat? Like 1 2 3 4 5 6 7 1 2 3 4 5 6 7 1 2 3 4 5 6 7 Or would it incrementally continue up to 21?

cangerjun commented 5 months ago

Sure,the numbers repeat。 1 2 3 4 5 6 7 1 2 3 4 5 6 7 1 2 3 4 5 6 7 other request:You can add a national flag before the language for better differentiation.

Specy commented 5 months ago

Sure,the numbers repeat。 1 2 3 4 5 6 7 1 2 3 4 5 6 7 1 2 3 4 5 6 7 other request:You can add a national flag before the language for better differentiation.

Hmmm, wouldn't this layout be confusing? Is it being used by people already or is it something new?

I'll add the flag later

cangerjun commented 5 months ago

Sure,the numbers repeat。 1 2 3 4 5 6 7 1 2 3 4 5 6 7 1 2 3 4 5 6 7 other request:You can add a national flag before the language for better differentiation.

Hmmm, wouldn't this layout be confusing? Is it being used by people already or is it something new?

I'll add the flag later

In Chinese keyboard performance software, numbers are used as key pitch displays. The difference between 1234567 with different pitches lies in whether there are dots above or below, and how many dots there are.

cangerjun commented 5 months ago

There is also a notation system from Europe, which is now called Numbered Musical Notation. This is my YouTube channe lhttps://www.youtube.com/@NiyasanAnimeonflute The video I uploaded is the musical score recorded using this notation method.

Specy commented 5 months ago

Ok so it would be repeating numbers + dots below, that might be a bit harder to do as I'd have to use icons for the text which is not currently supported, perhaps there is some unicode way to add dots above characters?

ptr2019 commented 5 months ago

Ok so it would be repeating numbers + dots below, that might be a bit harder to do as I'd have to use icons for the text which is not currently supported, perhaps there is some unicode way to add dots above characters?

We have: U+0307 for dot above: https://www.compart.com/en/unicode/U+0307 and U+0323 for dot below: https://www.compart.com/en/unicode/U+0323. Or more suitable ones can be found on this site.

Hopefully these help.

Specy commented 5 months ago

ok maybe something like this? ̥1̥ an issue with numbers is that a single dot appears on the top/bottom right (1̥ ), so i had to add the dot to a "space" behind it, which is not the best solution.

Edit: seems like on my phone it looks differently than on PC, so even more confusing, I guess for now better not do it

ptr2019 commented 5 months ago

Yeah, I think so. Btw, how about adding translation to the "Note name" drop down, e.t.c., and distinguishing the notes in different octaves with numbers, e.g. "C4" vs "C5", which could be easier than implementation for numbered musical notation mentioned above (for further attempt on numbered musical notation, https://github.com/w3c/smufl/issues/80 might help). 图片

Specy commented 5 months ago

Yes i was looking for places I missed to translate and found a few, I've added them to a list, I won't be home for a few days so I'll continue the work when I come back, also @cangerjun or @ptr2019 can you please create a new issue for this music notes format?

ptr2019 commented 5 months ago

Ready now, as done by @cangerjun .

cangerjun commented 4 months ago

议题已经陈旧,已经有一个同类型议题,这个议题暂时关闭