Add more languages

[qaq1000w]

Support multiple languages,Such as Chinese

支持多种语言，如中文 感谢

[Specy]

It's on the list for the 4.0 release, but it's a huge effort and might take a while to do

[cangerjun]

It's on the list for the 4.0 release, but it's a huge effort and might take a while to do

As long as you make the code you need translated publicly available, someone will come to complete the translation work.

[Specy]

As long as you make the code you need translated publicly available, someone will come to complete the translation work.

Yes that is the issue, making the underlying code work with translations

[Specy]

I'll see tomorrow if I can plan it out and start working on it, it will take precedence over held instruments

[Specy]

Ok it took me something like 12 hours of work to extract all the text into a single file, if someone wants to help adding the Chinese translations (or any other translations that is), the file is here: https://github.com/Specy/genshin-music/blob/Dev/src/i18n/locales/zh/index.ts Just need to replace the right side of each string with it's translated counterpart, anything inside {{ }} doesn't have to be changed example:

//original
 delete_song: `Are you sure you want to delete the song "{{song_name}}"?`
//translated (in italian)
 delete_song: `Sei sicuro di voler cancellare la canzone "{{song_name}}"?`

[qaq1000w]

Something like this? 类似这样？

[Specy]

@qaq1000w you can directly change the English one, I made a copy of the English one as reference to translate, @cangerjun seems to be working on the PR to add Chinese in #42,

[ptr2019]

Something like this? 类似这样？

It seems that a separate file is given for each language, which can be revised by translating the corresponding part. Nevertheless, this issue may not cause much trouble.

[Specy]

By the way, the beta where this translation is available is here: https://beta.sky-music.specy.app/ https://beta.genshin-music.specy.app/

[qaq1000w]

@qaq1000w你可以直接改英文的，我把英文的复制了一份作为参考翻译，@cangerjun似乎正在致力于在#42中添加中文的 PR ，

this is good

[cangerjun]

@qaq1000w你可以直接改英文的，我把英文的复制了一份作为参考翻译，@cangerjun似乎正在致力于在#42中添加中文的 PR ，

this is good

你把KEY的翻译写成语音高是不对的，key就是曲调的意思，键盘用简谱谢谢。

[qaq1000w]

@qaq1000w你可以直接改英文的，我把英文的复制一份作为参考翻译，@cangerjun似乎正在致力于在#42中添加中文的公关，

这很好

你把KEY的翻译写成语音高是不对的，key就是曲调的意思，键盘用简谱谢谢。

你来吧

[cangerjun]

@qaq1000w你可以直接改英文的，我把英文的复制了一份作为参考翻译，@cangerjun似乎正在致力于在#42中添加中文的 PR ，

this is good

在所有用到key的句子你都翻译成了音高，音高一般是指按键的音高。 然后bpm我认为并不需要翻译，翻译后很不习惯（节拍数很少有人这样讲），

[qaq1000w]

@qaq1000w你可以直接改英文的，我把英文的复制了一份作为参考翻译，@cangerjun似乎正在致力于在#42中添加中文的 PR ，

this is good

在所有用到key的句子你都翻译成了音高，音高一般是指按键的音高。 然后bpm我认为并不需要翻译，翻译后很不习惯（节拍数很少有人这样讲），

我现在没有在弄了

[qaq1000w]

你需要我协助吗

[cangerjun]

@qaq1000w你可以直接改英文的，我把英文的复制了一份作为参考翻译，@cangerjun似乎正在致力于在#42中添加中文的 PR ，

this is good

在所有用到key的句子你都翻译成了音高，音高一般是指按键的音高。 然后bpm我认为并不需要翻译，翻译后很不习惯（节拍数很少有人这样讲），

我现在没有在弄了

已经合并你的了，我去邮箱中和@Specy 说一下好了

[Specy]

@cangerjun I've merged the changes and published it in the beta app, if you want to make changes to the translation go ahead, i'm not sure what i'd have to change. I'll also ask reviews of the translation to other chinese users to make sure everything is correct.

Also if you want to make a PR for it, make sure to get the latest commits first and do the PR against the Dev branch, not the main branch

[ptr2019]

@qaq1000w你可以直接改英文的，我把英文的复制了一份作为参考翻译，@cangerjun似乎正在致力于在#42中添加中文的 PR ，

this is good

在所有用到key的句子你都翻译成了音高，音高一般是指按键的音高。 然后bpm我认为并不需要翻译，翻译后很不习惯（节拍数很少有人这样讲），

我现在没有在弄了

已经合并你的了，我去邮箱中和@Specy 说一下好了

有道理，这里key指的是调高（主音的音高）也好，还有bpm不用翻译也是。大佬有时间改一下可以嘛（还是理论水平不够，嘿嘿）。

[Specy]

If you find any issues in the translation or parts which were not translated, please let me know here

[Specy]

I added a few more things that need to be translated in here, including instrument names. Could someone translate them?

I also added the flags and put the language selection option in the settings of the composer and player

[cangerjun]

I added a few more things that need to be translated in here, including instrument names. Could someone translate them?

I also added the flags and put the language selection option in the settings of the composer and player

我已经完成翻译工作，而且在昨天的提交中我上传了一份README-ZH 文件，并且下原版README.me文件中添加了一段切换不同语言文件的代码。 I have completed the translation work, and in yesterday's submission, I uploaded a README-ZH file and added a code to switch between different language files in the original README.me file.

[Specy]

@cangerjun you had translated the instruments name and the other things that needed translation, but you closed the PR, there are still some thing left to translate, could someone finish those out?

I'll publish it live after those are finished

[ptr2019]

If you find any issues in the translation or parts which were not translated, please let me know here

It seems that the replacement is incomplete? The drop down menus of note type and instrument remain in English. What do you say?

[qaq1000w]

@Specy

doesn't seem to work 似乎没有起作用

[Specy]

Ah right I forgot the "note name type", I'll check later why the instrument aren't being translated

[Specy]

If you find any issues in the translation or parts which were not translated, please let me know here

It seems that the replacement is incomplete? The drop down menus of note type and instrument remain in English. ![图片] What do you say?

Ok i managed to fix this, it would take a lot of more effort to support adding the translation to "note name type" so for now i'll keep it as it is, i've fixed the instruments translation though

[qaq1000w]

I think it's settled. @ptr2019

[qaq1000w]

There is no translation function here @Specy

[Specy]

I added those plus a few more in the latest commit, check that commit to know which lines were added and that still need translation

We are almost there!

[ptr2019]

If you find any issues in the translation or parts which were not translated, please let me know here

It seems that the replacement is incomplete? The drop down menus of note type and instrument remain in English. ![图片] What do you say?

Ok i managed to fix this, it would take a lot of more effort to support adding the translation to "note name type" so for now i'll keep it as it is, i've fixed the instruments translation though

Got it.

I think it's settled. @ptr2019

Yes, I see.

I added those plus a few more in the latest commit, check that commit to know which lines were added and that still need translation

We are almost there!

Looking on it awa.

[Specy]

Ok so, everything seems to be done, i'll give this a few days to test everything out, if there are no issues i'll publish it

[Specy]

Ok so, everything seems to be done, i'll give this a few days to test everything out, if there are no issues i'll publish it

Nevermind! There are a few more xD look at the latest commit here

[Specy]

I have 3 more key to add:

        how_to_install: "How to add to home screen" //opens the blog on how to install the app to home screen
        click_to_add_time: "Click to add time",
        click_to_remove_time: "Click to remove time",

[Specy]

I was suggested to change those keys here: https://github.com/Specy/genshin-music/commit/4bbd943ad74ee283e491dbad75ea6c1d2da663e9 are they correct? @ptr2019

[ptr2019]

Only one thing to make sure: What does the term "connect" in line 101 mean? Does it indicate the connection to the Internet? Specifically, "联网" means "connecting to the Internet".

I have no objection on changing the other keys. Here is a detailed explanation:

Some of the wrong translations are corrected ("编辑" for "edit", while "退出" for "exit"), while some translations adopting the corresponding nicknames in the game are reasonable (e.g., ”屁琴“ as nickname for 低音提琴/”contrabass“. I have consulted on this) .

I have also confirmed that ”变音记号“ is the correct term for "accidental". Again, sorry for the lack of professionalism in music composition area.

[Specy]

Only one thing to make sure: What does the term "connect" in line 101 mean? Does it indicate the connection to the Internet? Specifically, "联网" means "connecting to the Internet".

It is more of a general term to "connect to something" in this case it's made to connect to other domains of the app to transfer data between them.

I have also confirmed that ”变音记号“ is the correct term for "accidental". Again, sorry for the lack of professionalism in music composition area.

Don't worry! You did a wonderful job with the translation!

[ptr2019]

Then ”连接“ is a general term appropriate to indicate "connect to something".

Glad to devote my efforts. It is quite a nice experience~

[Specy]

I've merged the translations to the main branch in commit 15591be, I also published the V3.4 update live (includes the translations)

Thanks for everyone who helped translating!