Specy / genshin-music

A music composer and song learning webapp made for the games Genshin and Sky Cotl. Made with Next.js, WebMIDI, WebAudio, pixi.js
https://specy.app/
MIT License
132 stars 35 forks source link

Translation added #53

Closed ptr2019 closed 5 months ago

ptr2019 commented 5 months ago

Translation is added for the theme setting and instruments, etc., and revises are made for several terms previously translated, based on personal experience after several days of usage.

Specy commented 5 months ago

@cangerjun what do you think?

ptr2019 commented 5 months ago

Admittedly I am not quite sure about the names of several instruments from the game Sky, which I am not familiar with, such as the light guitar (which sounds weak and light, seemingly with light string), and some of the sound effects, e.g., is the "bird call" simply "鸟叫" in the game, or another official name.

Specy commented 5 months ago

Admittedly I am not quite sure about the names of several instruments from the game Sky, which I am not familiar with, such as the light guitar (which sounds weak and light, seemingly with light string), and some of the sound effects, e.g., is the "bird call" simply "鸟叫" in the game, or another official name.

I'm gonna ask for some people who use the app to review the translation, also the "call" is the sound that animals make to "attract" other animals, like "a bird calling another bird"

ptr2019 commented 5 months ago

Sound for "attraction", aha, got it. Further review is also needed indeed. I have just found that in this game, the manta has its Chinese name as "遥鲲" and the spirit manta is "透明遥鲲"...

Specy commented 5 months ago

should i merge this in the meanwhile? or are you still working on it

ptr2019 commented 5 months ago

Both merging or not are okay for me. I have already finished my part↓

Admittedly I am not quite sure about the names of several instruments from the game Sky, which I am not familiar with, such as the light guitar (which sounds weak and light, seemingly with light string), and some of the sound effects, e.g., is the "bird call" simply "鸟叫" in the game, or another official name.

The rest could be left to community feedback↓

Admittedly I am not quite sure about the names of several instruments from the game Sky, which I am not familiar with, such as the light guitar (which sounds weak and light, seemingly with light string), and some of the sound effects, e.g., is the "bird call" simply "鸟叫" in the game, or another official name.

I'm gonna ask for some people who use the app to review the translation, also the "call" is the sound that animals make to "attract" other animals, like "a bird calling another bird"

Just merge the later version, if that is okay.

Specy commented 5 months ago

i'll see if i can find chinese speaking people who can give a review to this

ptr2019 commented 5 months ago

Sorry for closing the PR too soon >v<. It seems that the merging has not been done yet. I will just leave it here, then.

Specy commented 5 months ago

I'm gonna answer back here instead of the issue but, there is

        midi_status: "MIDI status",
        midi_access_denied: "MIDI access was denied, please allow it in the browser settings and reload the page",
        midi_access_unsupported: "MIDI is not supported in this browser",
        midi_access_pending: "Waiting for MIDI access...",
        midi_access_granted: "MIDI available!",

        new: "New",

that need translation.

I'm sorry for asking so many times to add translations, but i keep on adding things as i find/add new features xD

ptr2019 commented 5 months ago

I'm gonna answer back here instead of the issue but, there is

        midi_status: "MIDI status",
        midi_access_denied: "MIDI access was denied, please allow it in the browser settings and reload the page",
        midi_access_unsupported: "MIDI is not supported in this browser",
        midi_access_pending: "Waiting for MIDI access...",
        midi_access_granted: "MIDI available!",

        new: "New",

that need translation.

I'm sorry for asking so many times to add translations, but i keep on adding things as i find/add new features xD

Sure. Looking on it, awa.