search

Specy / genshin-music

A music composer and song learning webapp made for the games Genshin and Sky Cotl. Made with Next.js, WebMIDI, WebAudio, pixi.js
https://specy.app/
MIT License
133 stars 35 forks source link

add "Nightwind Horn" #60

Open Zackx087 opened 5 months ago

Zackx087 commented 5 months ago

Nightwind Horn is a Gadget obtained from the Iridescent Arataki Rockin' For Life Tour de Force of Awesomeness event. according to wiki fandom The notes only have 14 Item_Nightwind_Horn

ptr2019 commented 5 months ago

Just spotted this issue. In case the owner is too busy to answer in time, the following information is shared for your interest: As https://github.com/Specy/genshin-music/pull/59#issuecomment-2123545549 stated, the implementation for the new instrument is on the list.

Specy commented 5 months ago

I didn't forget, it will just take a huge amount of time to add sustained notes to the app, that's why I'm not releasing it yet. I could try to add it without sustain in the meanwhile and then add it in the future.

I'll make a poll in the community to see what they prefer, if either adding non sustained instrument for now, and then update in the future, or wait few months for the proper one to be released

ptr2019 commented 5 months ago

Non sustained version is fine for now～

ptr2019 commented 5 months ago

I didn't forget, it will just take a huge amount of time to add sustained notes to the app, that's why I'm not releasing it yet. I could try to add it without sustain in the meanwhile and then add it in the future.

I'll make a poll in the community to see what they prefer, if either adding non sustained instrument for now, and then update in the future, or wait few months for the proper one to be released

May I ask how is the poll going?

Specy commented 5 months ago

May I ask how is the poll going?

ptr2019 commented 4 months ago

Weeks have past~

May I ask something about the time schedule (e.g., is the framework ready now, with modules being implemented for those days).

Specy commented 4 months ago

I haven't had time to work on the app yet, I'm busy with work and university exams, (and I'm anxious about implementing this feature as it's huge work and I don't even know If it's gonna work)

ptr2019 commented 4 months ago

Got it. Work and study should be in the first place. As for the feature, just take your time (a huge and different work indeed).

ptr2019 commented 3 months ago

（A month later）

Specy commented 3 months ago

I know, i'm thinking of it everyday, i have the "last exam" of the month in a few days, after that i have a bit more free time to work on the app (hopefully)

ptr2019 commented 3 months ago

No worry :smile: Just to let you know that there are still ones concerning about the issue～This work would be meaningful.

ptr2019 commented 2 months ago

May I ask how is it going🙃(once again, awa)

Specy commented 2 months ago

Hello, I was in a bad burnout this month so i wasn't able to work on it.

I'm currently waiting for https://github.com/pixijs/pixi-react/issues/493 To be shipped, I need to update the codebase to next.js 14 (hopefully by the time pixi react updates, next.js 15 comes out) and react 18 (or 19), then I can work on adding tone.js for the audio part that's needed for sustained instruments. I'll also talk to the people at tone.js to know the best approach to implement this

ptr2019 commented 2 months ago

Hello, I was in a bad burnout this month so i wasn't able to work on it.

I'm currently waiting for pixijs/pixi-react#493 To be shipped, I need to update the codebase to next.js 14 (hopefully by the time pixi react updates, next.js 15 comes out) and react 18 (or 19), then I can work on adding tone.js for the audio part that's needed for sustained instruments. I'll also talk to the people at tone.js to know the best approach to implement this

Got it.