search

Speech-Rule-Engine / speech-rule-engine

Generating speech descriptions for XML structures
https://zorkow.github.io/speech-rule-engine/
Apache License 2.0
75 stars 39 forks source link

Korean Localization #637

Closed aintbe closed 1 year ago

aintbe commented 2 years ago

Related to ISSUE #539

Added Korean locale feature to SRE. This is up-to-date with your latest code in develop branch, and we checked that every test case passed. (For now, tests for some locales fails due to fetched upstream code, which I guess you're in the middle of develop. However, when we ran a test only for Korean locale, there was nothing going wrong.) I'd appreciate if you review & merge this PR.

Also, all of Korean test cases are uploaded here. I didn't open a PR since we had not generate output files for Korean, but if you're okay with it for now, I'll open one for that repository too.

zorkow commented 2 years ago

Many thanks for that PR. My apologies for not getting back to you on this, but I've been busy teaching and travelling. We are in the process of getting MathJax 4.2.1 out. Once that is out of the way I will have time and energy to review your work.