Speech-Rule-Engine / speech-rule-engine

Generating speech descriptions for XML structures
https://zorkow.github.io/speech-rule-engine/
Apache License 2.0
75 stars 39 forks source link

incomplete configuration causing some loss of whitespace in speech output #669

Closed pkra closed 2 years ago

pkra commented 2 years ago

I understand if this a won't-fix but I thought I'd share it in any case.

I was flummoxed over the weekend trying to figure out why something like FU ( \\mathbf{t} ) was giving me upper Fupper Uleft parenthesisboldtright parenthesis (note the dropped whitespace).

Turns out my configuration was missing something:

  await sre.setupEngine({
    domain: 'mathspeak',
    style: 'default',
    locale: 'en',
    speech: 'deep',
    structure: true,
    mode: 'sync',
  });

namely, adding modality: 'speech' fixed the issue.

Since the domain only allows this modality, maybe modality could be set automatically. But again, I understand if this isn't worth the trouble.

zorkow commented 2 years ago

Is it possible that you ran SRE with modality: 'braille' beforehand? Than the standard string separator would be ''.

At the moment there is no automation that maps from locales or domains to modalities.

pkra commented 2 years ago

Is it possible that you ran SRE with modality: 'braille' beforehand?

Effectively, yes.

Than the standard string separator would be ''. At the moment there is no automation that maps from locales or domains to modalities.

Right. Maybe incomplete configurations could cause a warning. But that's a different issue.