search

Speedweener / pe

0 stars 0 forks source link

Confusing Class diagram for logic component #17

Open Speedweener opened 3 years ago

Speedweener commented 3 years ago

image.png

The arrows are quite messy, with some dotted lines turning into solid lines, and dotted lines emerging from soolid lines. Should also use labels to clearly depict the types of relationships in the diagram.

The box for Parser should also be of another colour/thickness to avoid confusion with the arrows

nus-pe-bot commented 3 years ago

Team's Response

Yes, on hindsight the overlapping of the lines could have been avoided.

Tha Parser package lines are just a minor aesthetic issue and is still quite clear.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: Hmm i think this severity should be at least Medium, because as a developer, I would still be confused as to whether classes like HelpParser or MemberParser actually implement the interface ExceptionsParser, since there is no apparent dotted line pointing towards the interface. Also, labels should be used to show the type of association between the classes.