search

Speedygeek / ZendeskApi_v2

C# wrapper for the Zendesk API
Other
170 stars 200 forks source link

Macro pagination #564

Closed CanisHelix closed 2 years ago

CanisHelix commented 2 years ago

Add Pagination to GetAllMacro's. I was having issues with 1800 macro's. Not sure why this includes my old commits, it just won't remove them from the PR.

mozts2005 commented 2 years ago

To clean your fit history you will need to update your fork of the project.

also please add a test case for this change.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

CanisHelix commented 2 years ago

Regular sync wasn't working for some reason, said my branch was ahead. Did a forced rebase to upstream/master and looks cleaner. Added a test, but had to reduce to 5 per page as the CI account seems to only have 21 macros available to it.