search

SpellholdStudios / NTotSC

NTotSC v2.x.y for BGT, BG:EE, and EET
7 stars 9 forks source link

Improved Lesser Fiends Component : missing scripts #42

Closed TotoR115 closed 2 years ago

TotoR115 commented 2 years ago

@AngelGryph, the component Improved Lesser Fiends does not install the new dedicated scripts for fiends:

AngelGryph commented 2 years ago

Yep, looks like I made an oversight when changing script names. Will fix, thanks for the report.

Gitjas commented 2 years ago

Turns out I can't fix this because I don't undestand what the function is doing. :-(

AngelGryph commented 2 years ago

I already fixed this one on my branch. I wanted to wait until I have more to add, but I can make a pull request now if you really want to have it.

Gitjas commented 2 years ago

I'm preparing a new version, so I'd take anything I can get. :-) Unless you think a new version now wouldn't make sense without your further input. I checked your fork but didn't see a fix, seems I'm not really versed with GitHub.

Gitjas commented 2 years ago

No rush, though. I just figured I'd have to update the readme, too. These things usually take more time.

AngelGryph commented 2 years ago

I haven't pushed them yet, they are local on my machine. I'll run some quick tests and get them out ASAP.

I wanted to do more testing and fine-tuning on the tactical components, but I never seem to get to it. I have so much stuff to test and go through on my next BG1 run. They do work on a basic level though.

Gitjas commented 2 years ago

Cool! Would you include a short blurb about what the new components are doing, nothing detailed just a one-liner for each for the readme description?

Gitjas commented 2 years ago

I meant anything more detailed than "this component improves the fight with [insert foe name]" in case it makes sense. :-) Because that I can write if you think it suffices.

AngelGryph commented 2 years ago

Done. I did quick tests and everything installs cleanly on BGEE and BGT.