search

SpellholdStudios / NTotSC

NTotSC v2.x.y for BGT, BG:EE, and EET
7 stars 9 forks source link

Added Spanish translation #66

Closed AngelGryph closed 3 months ago

AngelGryph commented 10 months ago

Spanish translation by alaisFcZ. I'm only uploading it, I do not speak a word of Spanish myself.

Roberciiik commented 4 months ago

Hello @AngelGryph ! Could you please update the README file with the authors of the translation? Thank you!

11jo commented 3 months ago

Hello @Roberciiik,

I just receive a message from AlaisFcZ the autor of the Spanish translation asking if it's possible to merge it officially.

Do you want me to send you a pull request with the author name in the readme to facilitate things for him ?

Roberciiik commented 3 months ago

Hello @Roberciiik,

I just receive a message from AlaisFcZ the autor of the Spanish translation asking if it's possible to merge it officially.

Do you want me to send you a pull request with the author name in the readme to facilitate things for him ?

@11jo Yes, please, if you would like to update this or create a new PR, then I will be happy to merge it. I am not sure why @AngelGryph updated CRE file. Probably not finished Castilian language should be removed as it is northern version of Spanish.

11jo commented 3 months ago

aaa

For the cnkrotan.cre, I did some comparaison and the change seem very justified.

...

But all the ogg files are in english, so I guess there is no need to duplicate them.

...

Do you prefer to merge the pull request and then, I send a new one to delete useless ogg and add a mention in the readme or we try to contact @AngelGryph another way and redo the pull request entierely ?

Roberciiik commented 3 months ago

I will merge that one, and you could remove ogg files (as install script will use English if local is not provided). And also add proper README recognition.

Roberciiik commented 3 months ago

Closing as your changes are added in #74