PDF417 Support - Githubissues

adearmasIAP commented 3 years ago

Hello, I have finished PDF417 translation from C# to Delphi. It compiles just fine althought there's a lot of work to do left:

First of all Camera demo it does not work beause it cancels with AVs when it detects a PDF417 code. I cleaned up some errors but, obviusly some remain.
There will be thousands of memory leaks because I tried to keep it as similar to the original as possible (Hoping to make it work fast but I failed).
I used a lot of compiler new goodies and I have to remove them to make ir compatible with older Delphi compilers.

I'd like to know if anyone with more experience than me would like to help to make ir work.

Regards.

Spelt commented 3 years ago

Did you continue developing your translation?

adearmasIAP commented 3 years ago

Hi!... The translation is complete. I've been chasing an AV raised when a QR is detected but I couldn't fix it. The code compiles. I had to change some classes that were not well translated (AFAIK)

Do you have time to help me? It is still written in 10.4.2 ( I guess it compiles well in 10.4.x) because I wanted to keep it as original as the C# code looks like in order to make it work.

Regards

De: E Spelt @.> Enviado: domingo, 25 de abril de 2021 10:18 Para: Spelt/ZXing.Delphi @.> Cc: DE ARMAS ADRIAN ALFREDO @.>; Author @.> Asunto: Re: [Spelt/ZXing.Delphi] PDF417 Support (#115)

Did you continue developing your translation?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Spelt/ZXing.Delphi/issues/115#issuecomment-826323385, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDF76PS2UD57BNBFI46GN3TKQJEFANCNFSM4WR3NFZQ.

Spelt commented 3 years ago

Short term, I have zero time to spare. Long term I wil help but that won’t help you now.

On 25 Apr 2021, at 16:16, adearmasIAP @.***> wrote:

Hi!... The translation is complete. I've been chasing an AV raised when a QR is detected but I couldn't fix it. The code compiles. I had to change some classes that were not well translated (AFAIK)

Do you have time to help me? It is still written in 10.4.2 ( I guess it compiles well in 10.4.x) because I wanted to keep it as original as the C# code looks like in order to make it work.

Regards

De: E Spelt @.> Enviado: domingo, 25 de abril de 2021 10:18 Para: Spelt/ZXing.Delphi @.> Cc: DE ARMAS ADRIAN ALFREDO @.>; Author @.> Asunto: Re: [Spelt/ZXing.Delphi] PDF417 Support (#115)

Did you continue developing your translation?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/Spelt/ZXing.Delphi/issues/115#issuecomment-826323385, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDF76PS2UD57BNBFI46GN3TKQJEFANCNFSM4WR3NFZQ. — You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Spelt/ZXing.Delphi/issues/115#issuecomment-826331901, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAS3VKSLGT5SVU5VMHPUNLTKQP2ZANCNFSM4WR3NFZQ.

adearmasIAP commented 3 years ago

It is OK. I made the translation when I had the time. It is not a functionality that I need for my own, I just wanted to collaborate with something that needed a good count of hours. Every now and then, when I have the time, I keep chasing that AV.

Regards

Tajmi commented 2 years ago

@adearmasIAP Do you have any prototype source files with your PDF417 implementations?

adearmasIAP commented 2 years ago

Hello @Tajmi . I have the source code that I translated but it doesn't work at all. The project I was working bought some PDF417 reading devices so I had no need to keep investigating the implementation.

If anyone wants to take a look I will happily upload it.

Tajmi commented 2 years ago

Hi @adearmasIAP I would realy like to look at it and try to fix it. Can you contact me on VTajmr@seznam.cz or upload the source files anywhere? Thank you.

adearmasIAP commented 2 years ago

Hello @Tajmi I have uploaded my code. I needed an implementation of bigintegers so I used http://rvelthuis.de/programs/bigintegers.html

The code does not work, it raises an AV. There's a lot of work to do: 1.Make it work 2.To keep backward compability lots of inline variables should be removed 3.Memory leaks... I tried to translate the code without changes (that's the reason of inline variables) and that produced lots of ML. My idea was remove them before uploading the result.

https://drive.google.com/file/d/1a1GCIu4Btke0wBXTDSPtjOOs9dW1hkRr/view?usp=sharing

Hope you can make it work

wilchaia commented 2 years ago

Did anyone could make PDF417 decode work?

Tajmr commented 2 years ago

Yes I kinda make it. But it was hell work.

Tajmr commented 2 years ago

I got it running on delphi XE4, but it is still quit buggy :/

adearmasIAP commented 1 year ago

Is it possible to get the code and see if I can help?

De: Tajmr @.> Enviado: miércoles, 8 de junio de 2022 11:34 Para: Spelt/ZXing.Delphi @.> Cc: DE ARMAS ADRIAN ALFREDO @.>; Mention @.> Asunto: Re: [Spelt/ZXing.Delphi] PDF417 Support (#115)

I got it running on delphi XE4, but it is still quit buggy :/

— Reply to this email directly, view it on GitHubhttps://github.com/Spelt/ZXing.Delphi/issues/115#issuecomment-1150002549, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDF76KHZ326JARW3ID7DULVOCVOXANCNFSM4WR3NFZQ. You are receiving this because you were mentioned.Message ID: @.***>

Tajmi commented 1 year ago

I can post the code at the evening somewhere. I am no longer maintaining it. But if it can help anyone else.

adearmasIAP commented 1 year ago

Yes please

De: Tajmi @.> Enviado: martes, 11 de octubre de 2022 7:10 Para: Spelt/ZXing.Delphi @.> Cc: DE ARMAS ADRIAN ALFREDO @.>; Mention @.> Asunto: Re: [Spelt/ZXing.Delphi] PDF417 Support (#115)

I can post the code at the evening somewhere. I am no longer maintaining it. But if it cant help anyone else.

— Reply to this email directly, view it on GitHubhttps://github.com/Spelt/ZXing.Delphi/issues/115#issuecomment-1274453455, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKDF76KXNBSUPWAWAZB4VFLWCU4JBANCNFSM4WR3NFZQ. You are receiving this because you were mentioned.Message ID: @.***>

balger commented 1 year ago

Unfortunately I cannot help due to lack of knowledge. But I need PDF417. Thanks. Thanks. Thank you very much

Spelt commented 1 year ago

Hi Tajmi

Can you post the code?

Spelt / ZXing.Delphi

PDF417 Support #115