Spelunking-Studios / The-Caverns-Original

An exploration ARPG game made in python with pygame
2 stars 1 forks source link

Rat Boss in final stage can hit player beyond the visible image #7

Open https123456789 opened 2 years ago

https123456789 commented 2 years ago

The Problem

Well, the title kinda says it.

Potential Fix?

Either dynamically shrink the size of the rat or have a prop that indicates a distinct "reach" and that is dynamically updated.

LGgameLAB commented 2 years ago

A better fix would be to use circular collision or if you wanna be extra fancy, mask collision

On Tue, Aug 23, 2022, 8:54 PM Ben Landon @.***> wrote:

The Problem

Well, the title kinda says it. Potential Fix?

Either dynamically shrink the size of the rat or have a prop that indicates a distinct "reach" and that is dynamically updated.

— Reply to this email directly, view it on GitHub https://github.com/LGgameLAB/The-Caverns/issues/7, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK6UKULUMBXYWBATWSFLV43V2WMIJANCNFSM57NXGG2Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>

https123456789 commented 2 years ago

I'll probably go with mask collision, but this is low on my priority list. I need to get the basics of the inventory system functioning.

LGgameLAB commented 2 years ago

Mask collision is very computationally heavy especially because the image is rapidly flickering (you would have to preload the mask for each frame which would save computation but increase memory). I recommend circle collision that is dependent on the stage since that'll be the quickest. Good luck with inventory. When Matthew produces a few more gud items, I'll get the HUD looking good 👍

On Tue, Aug 23, 2022, 9:02 PM Ben Landon @.***> wrote:

I'll probably go with mask collision, but this is low on my priority list. I need to get the basics of the inventory system functioning.

— Reply to this email directly, view it on GitHub https://github.com/LGgameLAB/The-Caverns/issues/7#issuecomment-1225161994, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK6UKUJZMXRMGCAVPCBMWQTV2WNE5ANCNFSM57NXGG2Q . You are receiving this because you commented.Message ID: @.***>

https123456789 commented 2 years ago

The HUD is separate from the inventory overlay right?