SpenceKonde / ATTinyCore

Arduino core for ATtiny 1634, 828, x313, x4, x41, x5, x61, x7 and x8
Other
1.57k stars 306 forks source link

Special characters in branch name "v2.0.0-dev<This-is-the-head,-submit-PRs-against-this" #722

Closed HendryKaak closed 2 years ago

HendryKaak commented 2 years ago

Hello SpenceKonde,

I tried to clone this repository (which is a submodule in my repo) and found out that you suddenly renamed the master branch to a new and very extensive name. That's well and all, but git doesn't seem too happy about the special character usage in the branch name without escape characters in the name. .gitmodules also doesn't accept special characters as is. Is it possible to remove the special characters such as '<' (and perhaps ',' ?) in the default v2.0.0-dev<This-is-the-head,-submit-PRs-against-this branch? That would avoid the problem altogether.

See:

$ git checkout 'v2.0.0-dev<This-is-the-head,-submit-PRs-against-this'
fatal: cannot lock ref 'refs/heads/v2.0.0-dev<This-is-the-head,-submit-PRs-against-this': Unable to create 'D:/git-repositories/ATTinyCore/.git/refs/heads/v2.0.0-dev<This-is-the-head,-submit-PRs-against-this.lock': Invalid argument

Edit: Thinking about this issue again, this may be a Windows related problem (the OS I'm working with at the moment). A naming related problem due to NTSF naming restrictions, see here

SpenceKonde commented 2 years ago

Yes I just fucking noticed this myself....

On Thu, Sep 8, 2022 at 9:24 AM Hendry Kaak @.***> wrote:

Hello SpenceKonde,

I tried to clone this repository (which is a submodule in my repo) and found out that you suddenly renamed the master branch to a new and very extensive name. That's well and all, but git doesn't seem too happy about the special character usage in the branch name without escape characters in the name. .gitmodules also doesn't accept special characters as is. Is it possible to remove the special characters such as '<' (and perhaps ',' ?) in the default v2.0.0-dev<This-is-the-head,-submit-PRs-against-this branch? That would avoid the problem altogether.

See:

$ git checkout 'v2.0.0-dev<This-is-the-head,-submit-PRs-against-this' fatal: cannot lock ref 'refs/heads/v2.0.0-dev<This-is-the-head,-submit-PRs-against-this': Unable to create 'D:/git-repositories/ATTinyCore/.git/refs/heads/v2.0.0-dev<This-is-the-head,-submit-PRs-against-this.lock': Invalid argument

— Reply to this email directly, view it on GitHub https://github.com/SpenceKonde/ATTinyCore/issues/722, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTXEW377GUFZCKPK2EPPDTV5HSHJANCNFSM6AAAAAAQHX2TOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--


Spence Konde Azzy’S Electronics

New products! Check them out at tindie.com/stores/DrAzzy GitHub: github.com/SpenceKonde ATTinyCore https://github.com/SpenceKonde/ATTinyCore: Arduino support for all pre-2016 tinyAVR with >2k flash! megaTinyCore https://github.com/SpenceKonde/megaTinyCore: Arduino support for all post-2016 tinyAVR parts! DxCore https://github.com/SpenceKonde/DxCore: Arduino support for the AVR Dx-series parts, the latest and greatest from Microchip! Contact: @.***

SpenceKonde commented 2 years ago

Done.

HendryKaak commented 2 years ago

Thank you very much :-)