search

SpencerPearson / helipad-for-raspiblitz

Install Podcast Index's Helipad app on your Raspiblitz node!
3 stars 1 forks source link

raspiblitz script is renamed #5

Closed adevoss closed 2 years ago

adevoss commented 2 years ago

Required for the next raspiblitz release regardless the device.

valcanobacon commented 2 years ago

I see the script defined in 1.7 https://github.com/rootzoll/raspiblitz/blob/v1.7/home.admin/config.scripts/internet.hiddenservice.sh can you reference where its changing please

adevoss commented 2 years ago

It is changed in the dev branch. That will be the next release if I understood it correctly.

valcanobacon commented 2 years ago

I found this on the dev branch https://github.com/rootzoll/raspiblitz/blob/dev/home.admin/config.scripts/tor.install.sh. How do you know this is the change? Is there a specific commit or MR you saw?

If this is the correct change we should not merge in until the next version of raspiblitz is released.

valcanobacon commented 2 years ago

This appears to be the MR https://github.com/rootzoll/raspiblitz/pull/2419

valcanobacon commented 2 years ago

This looks good to me then. I am not sure what version of raspiblitz will contain this release. After it is released we should test this and merge if it is good.

adevoss commented 2 years ago

The thing that has changed is the name of the file. It was internet.hiddenservice.sh and in dev now it is tor.onion-service.sh Could be part of rootzoll/raspiblitz#2419 I don't know.

My guess is that it will be part of the next release. As I understand it the dev branch on raspiblitz is the next release.