Spenhouet / tensorboard-aggregator

Aggregate multiple tensorboard runs to new summary or csv files
MIT License
166 stars 27 forks source link

readme link to tensorboard-reducer for PyTorch? #8

Closed janosh closed 3 years ago

janosh commented 3 years ago

I created a pip-installable package with similar functionality to this repo over at https://github.com/janosh/tensorboard-reducer.

It's targeted at PyTorch users and doesn't require a TensorFlow installation. How about we each add a readme link to the other's repo suggesting users of the other framework look there instead?

Spenhouet commented 3 years ago

Hi @janosh,

this tool was not targeted at tensorflow users specifically. It should also be useable by pytorch users. In the last year I did not really had any use for it myself and therefore did not actively maintain it or nicely package it as you did. Maybe I will in the future.

I nonetheless added a readme link to your project, see: https://github.com/Spenhouet/tensorboard-aggregator/blob/master/README.md

janosh commented 3 years ago

I nonetheless added a readme link to your project, ...

Thanks a lot! Same here. No need to mention me by name in your readme though. 😅

this tool was not targeted at tensorflow users specifically. It should also be useable by pytorch users.

Since you're importing tf.summary and Event from tensorflow.core.util.event_pb2, this tool does require a TF 1.x installation, if I'm not mistaken. Since most of ML research uses PyTorch these days and TF 1.x usage is shrinking, I thought I'd be good to have a tool without that dependency as well.

Spenhouet commented 3 years ago

No need to mention me by name in your readme though.

Would you prefer that I remove your name from there?

this tool does require a TF 1.x installation

That is true. I don't really see the problem with that since it is just another python package someone needs to have installed. A thing of some seconds. I therefore do not worry to much about the summary being written by TF or pytorch.

EDIT: The only issue is that TF 1.x is relatively out-dated by now. If I would update this package, I would probably also do it with pytorch.

janosh commented 3 years ago

Would you prefer that I remove your name from there?

Sure, I'm all for brevity. :)

Spenhouet commented 3 years ago

No problem. Done :)