SpheMalo / phpsvnclient

Automatically exported from code.google.com/p/phpsvnclient
0 stars 0 forks source link

getFileLogs() using initial revision with no changes. #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Assume or create a repository where there is a directory example/, and a 
revision M which makes no changes to example/, and a revision N which does make 
changes to example/, where M < N.
2. perform a getFileLogs() on example/ with initial revision M and end revision 
N.

What is the expected output? What do you see instead?
I expect the output to show all revisions with changes after revision M and up 
to and including revision N.

The actual output is missing the lowest revision R where M < R <= N

e.g.
M = 19 (no changes to example/)
R = 22 (changes to example/)
N = 26 (changes to example/)

What version of the product are you using? On what operating system?
Revision 60.

Please provide any additional information below.
The functionality implies that getFileLogs() returns a diff. The code therefore 
attempts to exclude the log of the initial revision (which is actually a diff 
to the previous revision).
The class removes the first log item, assuming it is equal to the initial 
revision. In practise the first log item is not always equal to the initial 
revision.

Original issue reported on code.google.com by lawsonjeremy@gmail.com on 13 Jul 2010 at 3:10

Attachments:

GoogleCodeExporter commented 9 years ago
In the newer version of a similar error is present. Only here the "faulty" code 
looks like this:
array_shift ($ arrOutput ['children']);
This bug was corrected in the branch [khartn 
http://code.google.com/p/phpsvnclient/source/browse/#svn%2Fbranches%2Fkhartn], 
plans to eventually merge trunk with branch khartn.

Original comment by forpdfse...@gmail.com on 11 Jun 2011 at 9:51

GoogleCodeExporter commented 9 years ago

Original comment by forpdfse...@gmail.com on 11 Jun 2011 at 9:51

GoogleCodeExporter commented 9 years ago

Original comment by forpdfse...@gmail.com on 26 Jul 2011 at 4:07