search

Sphereon-Opensource / OID4VC

OpenID for Verifiable Credentials - modules for issuers, holders and RPs
Apache License 2.0
62 stars 19 forks source link

fix: use seconds for all expires in values #101

Closed TimoGlastra closed 6 months ago

TimoGlastra commented 6 months ago

Seems there were some other places were milliseconds were used, but the specs describe to use seconds for iat, exp, c_nonce_expires_in, interval and expires_in

I modified some defaults, so this is technically a breaking change, but I think the current implementation is incorrect so it could also be seen as a fix I think.

TimoGlastra commented 6 months ago

Given we are still at 0.x, breaking changes are allowed ;)

That's why Credo has been in 0.x for years now 🙃