Sphereon-Opensource / OID4VC

OpenID for Verifiable Credentials - modules for issuers, holders and RPs
Apache License 2.0
62 stars 19 forks source link

cNonce is not checked for expiration #103

Open TimoGlastra opened 5 months ago

TimoGlastra commented 5 months ago

I see that the cNonce used in a request is not checked for expiration.

What is checked is whether the credential request jwt iat (which is client-generated so not really trustable) is within the token expiration.

As I understand it, the token expiration for the access token expiration, and so instead of verifying the credential request jwt against the token expiration time, we should check it against the cNonce expiration time, to check if the cNonce used in the request hasn't expired yet.

Is that correct?