search

Sphereon-Opensource / OID4VC

OpenID for Verifiable Credentials - modules for issuers, holders and RPs
Apache License 2.0
65 stars 20 forks source link

fix: sdjwtvc decode hasher dependency #121

Closed auer-martin closed 3 months ago

auer-martin commented 3 months ago

This PR fixes two small problems.

In the VcIssuer file, the issuer is determined by decoding the credential into a standardized format with an issuer field. Decoding the issuer requires a hash implementation for compact sdjwt's. To work around this, I made the issuer an argument. The second problem concerns the implementation of token validation in combination with a PIN and compatibility with v11 and v13.

nklomp commented 3 months ago

Hmzz, probably some tests will fail as this one has overlap with #118

nklomp commented 3 months ago

@auer-martin Suggest to leave out the tx_code fix. We will then address that in #118

auer-martin commented 3 months ago

@nklomp done