search

Sphereon-Opensource / OID4VC

OpenID for Verifiable Credentials - modules for issuers, holders and RPs
Apache License 2.0
62 stars 19 forks source link

feat: dpop support #131

Closed auer-martin closed 1 month ago

auer-martin commented 1 month ago

This PR adds support for dPoP. DPoP support itself did not require many changes. Most of the changes made in this PR are refactorings, e.g., JwtIssuer and JwtVerifier to common so they can be reused ....sorry for that. Changes made for actual dpop support can be found in this commit. I open the PR as a draft for now, as I plan to go over the spec one last time in the next couple of days and add some tests.

auer-martin commented 1 month ago

Thanks @auer-martin . This probably became a way bigger PR than imagined. 😂

It was indeed a lot more work and took much longer than originally expected 🤣. I still need to test the integration with the PID issuer with these changes. Probably some small nits still need to be fixed than we can merge the PR.

TimoGlastra commented 1 month ago

@nklomp leaving final review / approval to you