Sphereon-Opensource / OID4VC

OpenID for Verifiable Credentials - modules for issuers, holders and RPs
Apache License 2.0
65 stars 20 forks source link

fix: content-type #24

Closed karimStekelenburg closed 1 year ago

karimStekelenburg commented 1 year ago

Uncommented this line because it broke the flow and resulted in the same error as mentioned in #18. Not sure if this breaks the Windows fix you did @nklomp...

Signed-off-by: Karim Stekelenburg karim@animo.id

codecov-commenter commented 1 year ago

Codecov Report

Merging #24 (fddc70b) into develop (0f031e9) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #24      +/-   ##
===========================================
+ Coverage    91.41%   91.42%   +0.01%     
===========================================
  Files           17       17              
  Lines          617      618       +1     
  Branches       154      155       +1     
===========================================
+ Hits           564      565       +1     
  Misses          50       50              
  Partials         3        3              
Flag Coverage Δ
unittest 91.42% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/functions/HttpUtils.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nklomp commented 1 year ago

Hmzz, it was always meant to be re-added again, but with a bit more complexity for handling corner cases. Totally forgot. Going to close this PR, as the adjusted code takes the custom headers and content-type argument into account and doesn't set the fallback application/json content-type header at all on a GET request. New version will be released shortly