fix: rename jwt_vc_json_ld to jwt_vc_json-ld and fixed test

Sphereon-Opensource / OID4VC

OpenID for Verifiable Credentials - modules for issuers, holders and RPs

Apache License 2.0

65 stars 20 forks source link

fix: rename jwt_vc_json_ld to jwt_vc_json-ld and fixed test #52

Closed berendsliedrecht closed 1 year ago

berendsliedrecht commented 1 year ago

According to https://openid.net/specs/openid-4-verifiable-credential-issuance-1_0.html#section-e.1 the format identifier for a VC signed as a JWT, using JSON-ld is jwt_vc_json-ld and not jwt_vc_json_ld.

Also, this fixes a small mistake, I assume, in the test where an extra 'Q' was added to the check.

nklomp commented 1 year ago

Hi @blu3beri thanks, yeah makes sense. Will have a look at it later.

The Q wasn't an error as all the tests pass. Because you changed the value it impacts the base64url encoding for the JWT, meaning the Q isn't valid anymore.