Sphereon-Opensource / OID4VC

OpenID for Verifiable Credentials - modules for issuers, holders and RPs
Apache License 2.0
63 stars 19 forks source link

A few type issues from Draft 13 #64

Open ejossev opened 1 year ago

ejossev commented 1 year ago

Hi again,

so I moved a bit forward with my tests and it seems the latest types (v11) do not match current draft 13:

https://github.com/Sphereon-Opensource/OID4VCI/blob/14d64614275f8cbeb5e4ece6e372c87ab7e33aaf/packages/common/lib/types/Generic.types.ts#L128 https://github.com/Sphereon-Opensource/OID4VCI/blob/14d64614275f8cbeb5e4ece6e372c87ab7e33aaf/packages/common/lib/types/Generic.types.ts#L107

Now the "types" is "type".

https://github.com/Sphereon-Opensource/OID4VCI/blame/6680088e6cc4c6dc9c7b05732acb7437ca4ddbfe/packages/common/lib/types/Generic.types.ts#L125 The credentialRequest is now united for both JOSE and LDP cases (as well as other types).

https://openid.bitbucket.io/connect/openid-4-verifiable-credential-issuance-1_0.html#name-w3c-verifiable-credentials

I know, it is pretty annoying with these unstable drafts breaking compatibility with each step, but are there plans for draft13 support?

nklomp commented 1 year ago

Hi @ejossev Thanks for bringing it up. We typically look at adoption of versions before implementing another version, which only adds complexity in the code. We cannot wait until v1 becomes ready and we can start deprecating certain versions.

Having said that. We currently support v8/v9 and v11. Currently the Jobs for the Future Plugfest is running which has a cohort that is focused on SIOPv2/OID4VP. But VCI is also implied, because that was a requirement in previous plugfest. Current participants seem to have settled on v11 as well. Although the type change is simple enough, there is also some other things we would need to change. Given our backlog I do not expect us to support v14 in the next 2 months tbh.

JuergenHoedl commented 2 months ago

How about the plans for draft 13 support one year later? I still see the "types" instead of "type" issue