search

Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
77 stars 25 forks source link

Feature/vdx 122/registration by reference uri #20

Closed hrehman-sphereon closed 2 years ago

hrehman-sphereon commented 2 years ago

@nklomp @sksadjad Can you please have a look at the commit with message "VDX-122 mark all places which need implementation." I think these are the only places where we need validation. Please confirm if these are correct.

We have 2 variables registration and registration_uri. Once I resolve it should I put it in returned objects or not.

nklomp commented 2 years ago

Can this be rebased on the v2 branch and ensure prettier is run, so that we do not have to go through all kinds of lines with different formatting

codecov-commenter commented 2 years ago

Codecov Report

Merging #20 (a01b2eb) into release/v2.0.0 (9bb4807) will decrease coverage by 0.43%. The diff coverage is 60.86%.

:exclamation: Current head a01b2eb differs from pull request most recent head 678058d. Consider uploading reports for the commit 678058d to get more accurate results

@@                Coverage Diff                 @@
##           release/v2.0.0      #20      +/-   ##
==================================================
- Coverage           84.71%   84.27%   -0.44%     
==================================================
  Files                  25       27       +2     
  Lines                1125     1145      +20     
  Branches              276      279       +3     
==================================================
+ Hits                  953      965      +12     
- Misses                170      178       +8     
  Partials                2        2
Flag Coverage Δ
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/AuthenticationResponse.ts 81.51% <ø> (ø)
src/main/functions/HttpUtils.ts 76.92% <ø> (ø)
...rc/main/schemas/DiscoveryMetadataPayload.schema.ts 0.00% <0.00%> (ø)
...in/schemas/RPRegistrationMetadataPayload.schema.ts 0.00% <0.00%> (ø)
src/main/types/SIOP.types.ts 97.19% <ø> (ø)
src/main/AuthenticationRequest.ts 81.37% <58.82%> (-3.86%) :arrow_down:
src/main/OP.ts 85.00% <100.00%> (+0.18%) :arrow_up:
src/main/types/Errors.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more