Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
77 stars 25 forks source link

WIP: Feature/vdx 103 linked domain validation #22

Closed sksadjad closed 2 years ago

sksadjad commented 2 years ago

verifying linked domain credentials

codecov-commenter commented 2 years ago

Codecov Report

Merging #22 (54a7336) into release/v2.0.0 (053dd9b) will decrease coverage by 0.43%. The diff coverage is 88.31%.

@@                Coverage Diff                 @@
##           release/v2.0.0      #22      +/-   ##
==================================================
- Coverage           84.71%   84.28%   -0.44%     
==================================================
  Files                  25       29       +4     
  Lines                1125     1196      +71     
  Branches              276      293      +17     
==================================================
+ Hits                  953     1008      +55     
- Misses                170      186      +16     
  Partials                2        2              
Flag Coverage Δ
unittest 84.28% <88.31%> (-0.44%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/schemas/AuthenticationRequestOpts.schema.ts 100.00% <ø> (ø)
.../main/schemas/AuthenticationResponseOpts.schema.ts 100.00% <ø> (ø)
src/main/functions/DidJWT.ts 76.10% <40.00%> (-0.42%) :arrow_down:
src/main/functions/LinkedDomainValidations.ts 70.37% <70.37%> (ø)
src/main/functions/Keys.ts 70.83% <80.00%> (ø)
src/main/AuthenticationRequestRegistration.ts 80.00% <84.21%> (-5.00%) :arrow_down:
src/main/AuthenticationRequest.ts 83.62% <85.96%> (-1.61%) :arrow_down:
src/main/OPBuilder.ts 85.10% <87.50%> (+1.01%) :arrow_up:
src/main/AuthenticationResponse.ts 81.19% <95.23%> (-0.32%) :arrow_down:
src/main/AuthenticationResponseRegistration.ts 100.00% <100.00%> (ø)
... and 16 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nklomp commented 2 years ago

PR has conflicts and build is failing

sksadjad commented 2 years ago

this pr also fixes https://github.com/Sphereon-Opensource/did-auth-siop/issues/21