Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
77 stars 25 forks source link

WIP: fix resolver configuration #28

Closed sksadjad closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #28 (77b1a5f) into release/v2.0.0 (c31bbf2) will decrease coverage by 0.01%. The diff coverage is 83.33%.

@@                Coverage Diff                 @@
##           release/v2.0.0      #28      +/-   ##
==================================================
- Coverage           83.20%   83.18%   -0.02%     
==================================================
  Files                  29       29              
  Lines                1268     1267       -1     
  Branches              318      292      -26     
==================================================
- Hits                 1055     1054       -1     
  Misses                213      213              
Flag Coverage Δ
unittest 83.18% <83.33%> (-0.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/OPBuilder.ts 85.10% <70.00%> (+2.08%) :arrow_up:
src/main/RPBuilder.ts 84.74% <70.00%> (-2.56%) :arrow_down:
src/main/functions/DIDResolution.ts 82.69% <84.37%> (-3.68%) :arrow_down:
src/main/OP.ts 89.74% <100.00%> (+3.72%) :arrow_up:
src/main/RP.ts 95.91% <100.00%> (+1.37%) :arrow_up:
src/main/functions/DidJWT.ts 75.22% <100.00%> (-0.89%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sksadjad commented 2 years ago

In general it looks good to me, can we improve the code coverage?

in th scope of this ticket, I don't think so. this is just for improving and unifying the way we're handling the resolver object

nklomp commented 2 years ago

See remark to place 2 remarks in the code