search

Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
Apache License 2.0
77 stars 25 forks source link

VDX-138 Check the signature of VC and VPs received in RP side #35

Closed maikel-maas closed 1 year ago

maikel-maas commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Merging #35 (966547c) into release/v2.0.0 (8345fe8) will increase coverage by 0.04%. The diff coverage is 90.00%.

@@                Coverage Diff                 @@
##           release/v2.0.0      #35      +/-   ##
==================================================
+ Coverage           84.04%   84.09%   +0.04%     
==================================================
  Files                  31       31              
  Lines                1423     1440      +17     
  Branches              360      365       +5     
==================================================
+ Hits                 1196     1211      +15     
- Misses                221      223       +2     
  Partials                6        6
Flag Coverage Δ
unittest 84.09% <90.00%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/schemas/AuthenticationResponseOpts.schema.ts 100.00% <ø> (ø)
src/main/types/SIOP.types.ts 97.65% <ø> (ø)
src/main/AuthenticationResponse.ts 75.00% <84.21%> (ø)
src/main/PresentationExchange.ts 79.81% <90.90%> (+<0.01%) :arrow_up:
src/main/RP.ts 92.98% <100.00%> (+0.38%) :arrow_up:
src/main/RPBuilder.ts 87.20% <100.00%> (+0.46%) :arrow_up:
src/main/types/Errors.ts 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nklomp commented 1 year ago

No. VP checks should always be performed