Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
Apache License 2.0
77 stars 25 forks source link

Feature/vdx 140/id1 profile #42

Closed maikel-maas closed 1 year ago

codecov-commenter commented 1 year ago

Codecov Report

Merging #42 (aa81d13) into release/v2.0.0 (dcc3632) will decrease coverage by 1.71%. The diff coverage is 79.37%.

@@                Coverage Diff                 @@
##           release/v2.0.0      #42      +/-   ##
==================================================
- Coverage           84.59%   82.88%   -1.72%     
==================================================
  Files                  31       34       +3     
  Lines                1487     1496       +9     
  Branches              386      381       -5     
==================================================
- Hits                 1258     1240      -18     
- Misses                224      247      +23     
- Partials                5        9       +4     
Flag Coverage Δ
unittest 82.88% <79.37%> (-1.72%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/AuthenticationRequestRegistration.ts 83.78% <ø> (ø)
src/main/AuthenticationResponseRegistration.ts 0.00% <0.00%> (-100.00%) :arrow_down:
...c/main/schemas/AuthenticationRequestOpts.schema.ts 100.00% <ø> (ø)
.../main/schemas/AuthenticationResponseOpts.schema.ts 100.00% <ø> (ø)
...rc/main/schemas/DiscoveryMetadataPayload.schema.ts 100.00% <ø> (ø)
...in/schemas/RPRegistrationMetadataPayload.schema.ts 100.00% <ø> (ø)
src/main/functions/SIOPVersionDiscovery.ts 55.00% <55.00%> (ø)
src/main/functions/DidJWT.ts 73.45% <63.63%> (-1.77%) :arrow_down:
src/main/AuthenticationRequest.ts 85.96% <79.31%> (-1.33%) :arrow_down:
src/main/types/SIOP.types.ts 97.67% <80.00%> (+0.01%) :arrow_up:
... and 17 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nklomp commented 1 year ago

Approving. Probably will go over some stuff again when refactoring some stuff for the v2 branch