search

Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
Apache License 2.0
77 stars 25 forks source link

fix: claims are not required #58

Closed berendsliedrecht closed 10 months ago

berendsliedrecht commented 1 year ago

I was using the library for the most simple did auth and it seems like the claims field it not required by the specification. However, it was difficult for me to find the exact answer to this as the spec did not seem to formally define this. In the data model, within this library, claims may be undefined so this would be inline with that.

nklomp commented 1 year ago

Claims are indeed not required. Because of a bug we ran into the same issue recently and it was fixed differently. Will leave this open to verify later this week, but should be resolved. Thanks for the PR