search

Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
Apache License 2.0
77 stars 25 forks source link

chore: some changes for JFF interop #61

Closed TimoGlastra closed 3 months ago

TimoGlastra commented 9 months ago

Have been tinkering a bit to get interop with MATTR launchpad.

It now seems to get stuck on the presentation definition validation, so will have to look at the PEX library for that.

Not sure if the JWT verification bypass is 'ok'. If there's no JWT I think it would be fine to just not validate it, but if there is one, it is validated.

Not ready to be merged, but if you do take a look, maybe these changes can be of help for getting the sphereon wallet working...

TimoGlastra commented 9 months ago

Awesome thanks! I wasn't aware that it replaces post. More version logic... 😅

nklomp commented 9 months ago

Yeah, long live evolving specs. I cannot wait once things settle down to start refactoring and remove a lot of the complexities from handling multiple versions..

BTW be aware that some changes have been made to this lib, mainly bugfixes

TimoGlastra commented 9 months ago

Got it working with this very hacky encoding logic. Not sure how you're on adding dependencies, but with qs it's a one liner :)

https://www.npmjs.com/package/qs?activeTab=dependencies

nklomp commented 9 months ago

FYI: I am taking some of the changes from this PR in the branch I am working on for V18 support

TimoGlastra commented 9 months ago

Yes, I was figuring that it's easiest if I push my 'hacks' and you can properly integrate it where needed. It's quite a mess in how I got things working :/