search

Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
77 stars 25 forks source link

Feature/onto 58 niels #7

Closed nklomp closed 3 years ago

nklomp commented 3 years ago

WIP/Draft PR. Allow multiple locations for VPs and claims according to spec. Move logic from RP/VP to Request/Response. Remove payload usage from opts. Fix logic errors.

Everything is working, but I need to do a final pass on the PR itself to see whether everything is as expected

codecov-commenter commented 3 years ago

Codecov Report

Merging #7 (fee4067) into develop (ce36eb6) will increase coverage by 0.44%. The diff coverage is 76.05%.

:exclamation: Current head fee4067 differs from pull request most recent head 1921d5c. Consider uploading reports for the commit 1921d5c to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #7      +/-   ##
===========================================
+ Coverage    87.17%   87.62%   +0.44%     
===========================================
  Files           25       25              
  Lines          889     1010     +121     
  Branches       169      208      +39     
===========================================
+ Hits           775      885     +110     
- Misses         113      123      +10     
- Partials         1        2       +1
Flag Coverage Δ
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/schemas/AuthenticationRequestOpts.schema.ts 100.00% <ø> (ø)
.../main/schemas/AuthenticationResponseOpts.schema.ts 100.00% <ø> (ø)
src/main/PresentationExchange.ts 77.52% <69.09%> (+28.74%) :arrow_up:
src/main/AuthenticationRequest.ts 86.81% <71.42%> (-4.86%) :arrow_down:
src/main/RPBuilder.ts 97.95% <80.00%> (-2.05%) :arrow_down:
src/main/types/SIOP.types.ts 94.04% <80.00%> (-1.90%) :arrow_down:
src/main/AuthenticationResponse.ts 85.47% <80.95%> (-2.53%) :arrow_down:
src/main/OP.ts 85.71% <100.00%> (+5.19%) :arrow_up:
src/main/RP.ts 91.66% <100.00%> (+0.17%) :arrow_up:
src/main/types/Errors.ts 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce36eb6...1921d5c. Read the comment docs.