search

Sphereon-Opensource / SIOP-OID4VP

Self Issued OpenID Provider v2 (SIOP) with optional OpenID for Verifiable Presentations (OpenID4VP)
77 stars 25 forks source link

ONTO-66: added redirectUri check to the RP #8

Closed sksadjad closed 2 years ago

sksadjad commented 2 years ago

added redirectUri to the payload of the authResponse. This way we can check the uri and prevent hijacking on the RP side

codecov-commenter commented 2 years ago

Codecov Report

Merging #8 (b56258e) into develop (787f1fa) will decrease coverage by 0.06%. The diff coverage is 60.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop       #8      +/-   ##
===========================================
- Coverage    87.59%   87.53%   -0.07%     
===========================================
  Files           25       25              
  Lines         1008     1011       +3     
  Branches       228      230       +2     
===========================================
+ Hits           883      885       +2     
- Misses         123      124       +1     
  Partials         2        2
Flag Coverage Δ
unittest 87.53% <60.00%> (-0.07%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/schemas/AuthenticationResponseOpts.schema.ts 100.00% <ø> (ø)
src/main/types/SIOP.types.ts 94.04% <ø> (ø)
src/main/AuthenticationResponse.ts 84.61% <50.00%> (-0.61%) :arrow_down:
src/main/OP.ts 85.91% <100.00%> (+0.20%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 787f1fa...b56258e. Read the comment docs.