search

Sphereon-Opensource / pex-openapi

Decentralized Identity Foundation : Presentation Exchange : API
Apache License 2.0
1 stars 6 forks source link

`jwt_vp_json` support? #34

Closed yhuard closed 6 months ago

yhuard commented 6 months ago

Hi! I see that you support jwt_vc_json but not jwt_vp_json, is it on purpose? In the PEX library, jwt_vp_json is used here https://github.com/Sphereon-Opensource/PEX/blob/d9b5c9e9272bbf1d9c96a5188ccefbcc7ea79c99/lib/evaluation/evaluationClientWrapper.ts#L452C36-L452C47

yhuard commented 6 months ago

Actually, in the PEX library, jwt_vp_json is not supported in the Presentation Definition either https://github.com/Sphereon-Opensource/PEX/blob/d9b5c9e9272bbf1d9c96a5188ccefbcc7ea79c99/resources/presentation_definition_v2.schema.json#L42

nklomp commented 6 months ago

No is not on purpose. It should indeed be in there in both places

yhuard commented 6 months ago

Thank you @nklomp, I was not sure if I was misinterpreting the specs or not.

It's a bit disturbing to have the OpenID4VP specs mention:

The Credential format identifiers are jwt_vc_json for a W3C Verifiable Credential and jwt_vp_json for W3C Verifiable Presentation.

while the PEX v2 specs relies on the Claim Format Registry which does not define jwt_vc_json nor jwt_vp_json.

nklomp commented 6 months ago

Yeah agree. That is also one of the reasons this went wrong probably. The OID4VP spec added new formats not in the registry. PEX-models has been updated (2.2.2). New PEX version will follow shortly